Export driver #177
Merged
Export driver #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoubleDi
reviewed
Feb 21, 2024
DoubleDi
reviewed
Feb 21, 2024
clickhouse.go
Outdated
| @@ -6,15 +6,15 @@ import ( | |||
| ) | |||
|
|
|||
| func init() { | |||
| sql.Register("chhttp", new(chDriver)) | |||
| sql.Register("chhttp", new(ChDriver)) | |||
There was a problem hiding this comment.
please update tests and examples
maltsev25
approved these changes
Feb 22, 2024
maltsev25
approved these changes
Feb 22, 2024
|
I checked the failing tests but couldn't find any relation between my pr. Do you know what is the issue in there? @DoubleDi |
Trezcool
approved these changes
Feb 26, 2024
|
@cemezgin please update to the latest master branch. The tests are fixed there |
DoubleDi
reviewed
Feb 27, 2024
README.md
Outdated
| @@ -267,6 +267,11 @@ func main() { | |||
| } | |||
| } | |||
| ``` | |||
| Use with trace | |||
There was a problem hiding this comment.
please add reference link to sqltrace
There was a problem hiding this comment.
okay I put a full datadog tracing example
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting driver to enable sqltrace integration